Re: [PATCH v2 3/3] cpufreq: qcom-nvmem: add compatible fallback for ipq806x for no SMEM
From: Konrad Dybcio
Date: Tue Nov 04 2025 - 07:17:40 EST
On 11/4/25 12:59 PM, Christian Marangi wrote:
> On Sat, Nov 01, 2025 at 12:42:55PM -0500, Bjorn Andersson wrote:
>> On Fri, Oct 31, 2025 at 02:08:34PM +0100, Christian Marangi wrote:
>>> On some IPQ806x SoC SMEM might be not initialized by SBL. This is the
>>> case for some Google devices (the OnHub family) that can't make use of
>>> SMEM to detect the SoC ID.
>>>
>>> To handle these specific case, check if the SMEM is not initialized (by
>>> checking if the qcom_smem_get_soc_id returns -ENODEV) and fallback to
>>> OF machine compatible checking to identify the SoC variant.
>>>
>>> Notice that the checking order is important as the machine compatible
>>> are normally defined with the specific one following the generic SoC
>>> (for example compatible = "qcom,ipq8065", "qcom,ipq8064").
>>>
>>> Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx>
>>
>> Reviewed-by: Bjorn Andersson <andersson@xxxxxxxxxx>
>>
>> And as mentioned in v1, this (cpufreq) patch can be merged independently
>> of the first two patches. So please merge it through the cpufreq tree.
>>
>
> I will send a new revision just for this patch so I can use
> of_match_node()
>
> Should be ok since it hasn't been picked right?
Yes, this is desired, even
Konrad