Re: [PATCH RESEND v4 4/4] sample: rust: pci: add tests for config space routines

[Danilo Krummrich]

On Tue Nov 4, 2025 at 3:27 PM CET, Zhi Wang wrote:
> +    fn config_space(pdev: &pci::Device<Core>) -> Result {
> +        let config = pdev.config_space()?;
> +
> +        // TODO: use the register!() macro for defining PCI configuration space registers once it
> +        // has been move out of nova-core.
> +        dev_info!(
> +            pdev.as_ref(),
> +            "pci-testdev config space read8 rev ID: {:x}\n",
> +            config.read8(0x8)
> +        );
> +
> +        dev_info!(
> +            pdev.as_ref(),
> +            "pci-testdev config space read16 vendor ID: {:x}\n",
> +            config.read16(0)
> +        );
> +
> +        dev_info!(
> +            pdev.as_ref(),
> +            "pci-testdev config space read32 BAR 0: {:x}\n",
> +            config.read32(0x10)
> +        );
> +
> +        dev_info!(
> +            pdev.as_ref(),
> +            "pci-testdev config space try_read8 rev ID: {:x}\n",
> +            config.try_read8(0x8)?
> +        );
> +
> +        dev_info!(
> +            pdev.as_ref(),
> +            "pci-testdev config space try_read16 vendor ID: {:x}\n",
> +            config.try_read16(0)?
> +        );
> +
> +        dev_info!(
> +            pdev.as_ref(),
> +            "pci-testdev config space try_read32 BAR 0: {:x}\n",
> +            config.try_read32(0x10)?
> +        );

If we want to demonstrate the fallible accessors we should try accesses outside
the bounds of the requested config space size. However, that doesn't really make
sense, because in this case the driver could have been calling
config_space_extended() instead.

So, I think the fallible versions don't really serve a purpose and we should
probably drop them.