Re: [PATCH] sfc: Fix double word in comments
From: Edward Cree
Date: Tue Nov 04 2025 - 12:40:54 EST
On 04/11/2025 00:24, Jakub Kicinski wrote:
> On Wed, 29 Oct 2025 15:21:31 +0800 Bo Liu wrote:
>> Remove the repeated word "the" in comments.
>>
>> Signed-off-by: Bo Liu <liubo03@xxxxxxxxxx>
>
> If you're doing typo-style fixes please fix all of the problems in
> the file.
FWIW this file is automatically generated from definitions managed
by the sfc firmware team, so typo fixes need to go to that upstream
source or they will just be overwritten next time the file is
regenerated. (We have tweaked the script to add a comment at the
top of the file explaining this, but we haven't pushed out a header
regeneration patch since then so it's not there yet.)
If Liu does produce a comprehensive typo-fix patch, I will do the
work to upstream the changes. But it doesn't seem worth it for a
single fix like this.
-ed