Re: [PATCH] regulator: core: disable supply if enabling main regulator fails

From: Mark Brown

Date: Fri Nov 07 2025 - 17:45:44 EST


On Fri, 07 Nov 2025 18:10:08 +0100, Gabor Juhos wrote:
> For 'always-on' and 'boot-on' regulators, the set_machine_constraints()
> may enable supply before enabling the main regulator, however if the
> latter fails, the function returns with an error but the supply remains
> enabled.
>
> When this happens, the regulator_register() function continues on the
> error path where it puts the supply regulator. Since enabling the supply
> is not balanced with a disable call, a warning similar to the following
> gets issued from _regulator_put():
>
> [...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: core: disable supply if enabling main regulator fails
commit: fb1ebb10468da414d57153ddebaab29c38ef1a78

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark