Re: [PATCH net-next] net: phy: mscc: Add support for PHY LEDs on VSC8541

[Andrew Lunn]

> Certainly the probes can be simplified into a single function. I'll
> create a patch for this.

Please do make sure of each device having its own .probe
pointer. Don't have one probe function with lots of if/else
clauses. Put what is device specific into a device specific probe, and
what is common into helpers.

> > Also, is the LED handling you are adding here specific to the 8541? If
> > you look at the datasheets for the other devices, are any the same?
> >
> Looking at the below datasheets the LED handlings seem to be the same.

That is common. So yes, please add it to them all. It does not matter
if you can only test one device.

	Andrew