Re: [PATCH] gpu: nova-core: apply the one "use" item per line policy

[Alexandre Courbot]

On Fri Nov 7, 2025 at 6:42 PM JST, Danilo Krummrich wrote:
> On Fri Nov 7, 2025 at 3:10 AM CET, John Hubbard wrote:
>> As per [1], we need one "use" item per line, in order to reduce merge
>> conflicts. Furthermore, we need a trailing ", //" in order to tell
>> rustfmt(1) to leave it alone.
>>
>> This does that for the entire nova-core driver.
>>
>> [1] https://docs.kernel.org/rust/coding-guidelines.html#imports
>>
>> Signed-off-by: John Hubbard <jhubbard@xxxxxxxxxx>
>
> Thanks for doing this!
>
> Few nits below, I assume Alex will fix them up on apply, so no need to resend.
>
> With those fixed,
>
> Acked-by: Danilo Krummrich <dakr@xxxxxxxxxx>

Applied these suggestions, thanks!

I've also noticed that sometimes the trailing `//` on the final line are
not always necessary if some intermediate sub-blocks already had one,
I've also removed such cases that do not affect rustfmt.

Planning on pushing tomorrow.