Re: [PATCH net v2] net: dsa: b53: bcm531x5: fix cpu rgmii mode interpretation

From: Andrew Lunn

Date: Fri Nov 07 2025 - 08:20:32 EST


> + /* Older driver versions incorrectly applied delays in
> + * PHY_INTERFACE_MODE_RGMII mode. In order to not break old users, keep
> + * interpreting RGMII as RGMII-ID.
> + */
> + if (interface == PHY_INTERFACE_MODE_RGMII)
> + interface = PHY_INTERFACE_MODE_RGMII_ID;

Did you look through the in kernel .dts files? How many systems does
this effect?

I would maybe add a dev_warn() here, saying the DT blob is out of date
and needs fixing. And fix all the in kernel .dts files.

Andrew