Re: [PATCH net-next] net: phy: mscc: Add support for PHY LEDs on VSC8541

[Russell King (Oracle)]

On Fri, Nov 07, 2025 at 10:34:32AM +0000, Lad, Prabhakar wrote:
> On Thu, Nov 6, 2025 at 8:45 PM Andrew Lunn <andrew@xxxxxxx> wrote:
> > > +static int vsc85xx_led_cntl_set_lock_unlock(struct phy_device *phydev,
> > > +                                         u8 led_num,
> > > +                                         u8 mode, bool lock)
> > >  {
> > >       int rc;
> > >       u16 reg_val;
> > >
> > > -     mutex_lock(&phydev->lock);
> > > +     if (lock)
> > > +             mutex_lock(&phydev->lock);
> > >       reg_val = phy_read(phydev, MSCC_PHY_LED_MODE_SEL);
> > >       reg_val &= ~LED_MODE_SEL_MASK(led_num);
> > >       reg_val |= LED_MODE_SEL(led_num, (u16)mode);
> > >       rc = phy_write(phydev, MSCC_PHY_LED_MODE_SEL, reg_val);
> > > -     mutex_unlock(&phydev->lock);
> > > +     if (lock)
> > > +             mutex_unlock(&phydev->lock);

If you used the provided helpers rather than open-coding a read-modify-
write, then you wouldn't even need this lock. Please use phy_modify().

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!