Re: [PATCH 01/12] dt-bindings: panel: Add Samsung SOFEF00 DDIC with panel
From: Krzysztof Kozlowski
Date: Fri Nov 07 2025 - 06:27:51 EST
On 07/11/2025 12:23, Neil Armstrong wrote:
> On 11/6/25 09:48, Krzysztof Kozlowski wrote:
>> On Tue, Nov 04, 2025 at 11:16:09PM +0100, David Heidelberg wrote:
>>> Basic description for S6E3FC2X01 DDIC with attached panels
>>>
>>> - Samsung AMS601NT22 6.01 inch, 1080x2160 pixels, 18:9 ratio
>>> - Samsung AMS628NW01 6.28 inch, 1080x2280 pixels, 19:9 ratio
>>>
>>> This panel has three supplies, while panel-simple-dsi is limited to one.
>>> There is no user of this compatible, nor the compatible make sense.
>>
>> There are. git grep samsung,sofef00, gives me two users.
>
> Hmm, on -next I only see a single one:
>
> $ grep samsung,sofef00 arch/*/boot/dts/ -R
> arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dts: compatible = "samsung,sofef00";
>
These are the users:
arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dts
drivers/gpu/drm/panel/panel-samsung-sofef00.c
>>
>>> Remove it from simple DSI panel definitions.
>
> Can't you mark is deprecated at first ?
Not sure what would be the benefit here. There is no negative ABI impact
here.
Best regards,
Krzysztof