Re: [PATCH v3 04/20] regulator: dt-bindings: add s2mpg11-pmic regulators

[André Draszik]

On Tue, 2025-11-04 at 10:39 +0100, Krzysztof Kozlowski wrote:
> On Mon, Nov 03, 2025 at 07:14:43PM +0000, André Draszik wrote:
> > +  The S2MPG11 PMIC provides 12 buck, 1 buck-boost, and 15 LDO regulators.
> > +
> > +  See also Documentation/devicetree/bindings/mfd/samsung,s2mps11.yaml for
> > +  additional information and example.
> > +
> > +definitions:
> 
> defs:

All existing bindings are using definitions, not defs. Shouldn't this stay
consistent?

[...]

> > +patternProperties:
> > +  # 12 bucks
> > +  "^buck(([1-9]|10)s|[ad])$":
> > +    type: object
> > +    $ref: regulator.yaml#
> > +    unevaluatedProperties: false
> > +    description:
> > +      Properties for a single buck regulator.
> > +
> > +    allOf:
> > +      - $ref: "#/definitions/s2mpg11-ext-control"
> 
> defs
> 
> > +
> > +    properties:
> > +      regulator-ramp-delay:
> > +        enum: [6250, 12500, 25000]
> > +        default: 6250
> > +
> 
> ....
> 
> 
> > +    allOf:
> > +      - $ref: "#/definitions/s2mpg11-ext-control"
> > +
> > +    properties:
> > +      regulator-ramp-delay:
> > +        enum: [6250, 12500]
> > +        default: 6250
> > +
> > +additionalProperties: false
> 
> This goes to the end, after allOf, see example-schema.

Will fix.

Thanks for your review Krzysztof.

Cheers,
A.