Re: [PATCH v3 02/20] dt-bindings: mfd: samsung,s2mps11: split s2mpg10 into separate file
From: André Draszik
Date: Fri Nov 07 2025 - 06:02:00 EST
Hi Krzysztof,
Thanks for your review.
On Tue, 2025-11-04 at 09:26 +0100, Krzysztof Kozlowski wrote:
> On Mon, Nov 03, 2025 at 07:14:41PM +0000, André Draszik wrote:
> > +properties:
> > + compatible:
> > + const: samsung,s2mpg10-pmic
> > +
> > + clocks:
> > + $ref: /schemas/clock/samsung,s2mps11.yaml
> > + description:
> > + Child node describing clock provider.
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + regulators:
> > + type: object
> > + description:
> > + List of child nodes that specify the regulators.
> > +
> > + system-power-controller: true
> > +
> > + wakeup-source: true
> > +
> > +required:
> > + - compatible
> > + - interrupts
> > + - regulators
> > +
> > +additionalProperties: false
>
> You need a complete example here.
Patch 7 adds / updates the example for these to the ACPM binding. I can extend that
example, but I'd prefer to keep it there to give it a bit more context. Adding an
example here would duplicate things.
Do you agree to that approach?
Thanks,
Andre