Re: [PATCH 1/3] dt-bindings: reset: add sky1 reset controller

[Krzysztof Kozlowski]

On 07/11/2025 04:38, Gary Yang wrote:
> +maintainers:
> +  - Gary Yang <gary.yang@xxxxxxxxxxx>
> +
> +description: |
> +  CIX Sky1 reset controller can be used to reset various set of peripherals.
> +  There are two reset controllers, one is located in S0 domain, the other
> +  is located in S5 domain.
> +
> +  See also:
> +  - dt-bindings/reset/cix,sky1-rst.h

Use full path here.

> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - cix,sky1-rst
> +          - cix,sky1-rst-fch
> +      - const: syscon
> +
> +  reg:
> +    maxItems: 2

You need to list the items.

> +
> +  '#reset-cells':
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - '#reset-cells'
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/reset/cix,sky1-rst.h>
> +    reset-controller@16000000 {
> +      compatible = "cix,sky1-rst", "syscon";
> +      reg = <0x0 0x16000000 0x0 0x1000>;

Clearly wrong - you said two items.

> +      #reset-cells = <1>;
> +    };


...


> +
> +#define SKY1_FCH_RESET_NUM	29

Drop, not ABI (usually).

> +
> +#endif
> +

...

> +
> +#define SKY1_RESET_NUM				143

Drop



Best regards,
Krzysztof