Re: [PATCH v3 2/2] dt-bindings: iio: proximity: Add Lidar-lite-v2 and v3
From: Rodrigo Gobbi
Date: Thu Nov 06 2025 - 19:37:11 EST
On 11/3/25 05:04, Krzysztof Kozlowski wrote:
> On 02/11/2025 23:10, Rodrigo Gobbi wrote:
>> Since v2 is not a trivial device, add it to a dedicated place. The v3 is
>
> What is v2 and v3? This patchset is v3, don't refer to it in the commit
> msg. If you speak about devices then make it obvious. How anyone going
> through `git log` can figure out what is v2. Your patch mentions some v2
> and v3 but these are different companies, so somehow completely
> different products?
Sorry for the commit msg, I`ll make it more clear in this case. About different companies, yes,
that is true. It turns out that this is a "special" case because lidar-lite-v2
chipset was manufactured by Pulsedlight vendor. In other hand, the new version from
it, v3, was manufactured by Garmin, which acquired the Pulsedlight.
In previous versions of this patch I`ve reviewed both datasheets, and the pin-out
is almost the same, that`s why I`ve added in the same binding.
Probably I`ll send a new patch version without using a patchset as pointed here and fixing the
subject/commit msg to make it more clear.
Feel free to suggest anything else or other concerns.
Tks and regards!!!