Re: [PATCH v3 2/2] ublk: use rq_for_each_segment() for user copy

From: Ming Lei

Date: Thu Nov 06 2025 - 19:10:56 EST


On Thu, Nov 06, 2025 at 10:16:47AM -0700, Caleb Sander Mateos wrote:
> ublk_advance_io_iter() and ublk_copy_io_pages() currently open-code the
> iteration over the request's bvecs. Switch to the rq_for_each_segment()
> macro provided by blk-mq to avoid reaching into the bio internals and
> simplify the code.
>
> Suggested-by: Ming Lei <ming.lei@xxxxxxxxxx>
> Signed-off-by: Caleb Sander Mateos <csander@xxxxxxxxxxxxxxx>

Nice cleanup:

Reviewed-by: Ming Lei <ming.lei@xxxxxxxxxx>


Thanks,
Ming