Re: [PATCH v3 0/4] nvme-fc: fix blktests nvme/041

[Justin Tee]

Hi Daniel,

Taking a different approach than this patch set, may we see if the
following singular patch resolves the nvme/041 blktest?

[PATCH 1/1] nvme-fabrics: add ENOKEY to no retry criteria for
authentication failures

With authentication, in addition to EKEYREJECTED there is also no point in
retrying reconnects when status is ENOKEY.  Thus, add -ENOKEY as another
criteria to determine when to stop retries.

Signed-off-by: Justin Tee <justintee8345@xxxxxxxxx>
---
 drivers/nvme/host/fabrics.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c
index 3d4d6d8e88c4..fb7765bf0cdf 100644
--- a/drivers/nvme/host/fabrics.c
+++ b/drivers/nvme/host/fabrics.c
@@ -594,7 +594,7 @@ bool nvmf_should_reconnect(struct nvme_ctrl *ctrl,
int status)
        if (status > 0 && (status & NVME_STATUS_DNR))
                return false;

-       if (status == -EKEYREJECTED)
+       if (status == -EKEYREJECTED || status == -ENOKEY)
                return false;

        if (ctrl->opts->max_reconnects == -1 ||
--
2.38.0

Regards,
Justin