Re: [PATCH v2 3/3] spi: add support for microchip "soft" spi controller

[Conor Dooley]

On Wed, Nov 05, 2025 at 04:18:30PM +0000, Mark Brown wrote:
> On Wed, Nov 05, 2025 at 03:28:23PM +0000, Prajna Rajendra Kumar wrote:
> 
> >  drivers/spi/Kconfig              |   9 +
> >  drivers/spi/Makefile             |   1 +
> >  drivers/spi/spi-microchip-core.c | 442 +++++++++++++++++++++++++++++++
> >  3 files changed, 452 insertions(+)
> 
> > +config SPI_MICROCHIP_CORE
> > +	tristate "Microchip FPGA SPI controllers"
> > +	depends on SPI_MASTER
> 
> Reusing the same filename and config symbol is almost certainly going to
> create issues and confusion for people upgrading their kernel or doing
> backports.  Perhaps CoreSPI instead?

The qspi driver (which is shared between SoC and FPGA IP) uses
SPI_MICROCHIP_CORE_QSPI, so probably SPI_MICROCHIP_CORE_SPI should be
used here. Prajna?

Attachment: signature.asc
Description: PGP signature