Re: [PATCH net-next v7 12/12] net: dsa: add driver for MaxLinear GSW1xx switch family

[Sverdlin, Alexander]

Hi Vladimir,

On Thu, 2025-11-06 at 19:29 +0200, Vladimir Oltean wrote:
> > # ip -d link show dev $dev
> > 4: lan1@eth0: <NO-CARRIER,BROADCAST,MULTICAST,PROMISC,UP> mtu 1500 qdisc noqueue state DOWN mode DEFAULT group default qlen 1000
> >      link/ether 00:a0:03:ea:fe:b7 brd ff:ff:ff:ff:ff:ff promiscuity 2 allmulti 0 minmtu 68 maxmtu 2378 
> >      dsa conduit eth0 addrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535 tso_max_size 65536 tso_max_segs 65535 gro_max_size 65536 gso_ipv4_max_size 65536 gro 
> 
> It partially does, yes. The promiscuity is 2, which suggests it was
> already 1 when has_unicast_flt() started to run. The function is not
> written to expect that to happen. Although I don't yet understand why
> lan1 originally entered promiscuous mode - that is not in your logs.
> 
> This is a separate environment from the selftest with the commands ran
> manually, no? Because you can just run the selftest with "bash -x".

Yes, I tried the above manually.
Let me repeat the test after a clean boot and with "bash -x", not that
we are debugging something different from the real test...

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com