Re: [PATCH net-next 03/10] dt-bindings: net: renesas,r8a779f0-ether-switch.yaml: add optional property link-pin

[Conor Dooley]

On Thu, Nov 06, 2025 at 01:55:27PM +0100, Michael Dege wrote:
> Add optional ether-port property link-pin <empty>

Whats this <empty> about?

> Signed-off-by: Michael Dege <michael.dege@xxxxxxxxxxx>
> ---
>  .../devicetree/bindings/net/renesas,r8a779f0-ether-switch.yaml         | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/renesas,r8a779f0-ether-switch.yaml b/Documentation/devicetree/bindings/net/renesas,r8a779f0-ether-switch.yaml
> index e933a1e48d67..54cd427d8ae5 100644
> --- a/Documentation/devicetree/bindings/net/renesas,r8a779f0-ether-switch.yaml
> +++ b/Documentation/devicetree/bindings/net/renesas,r8a779f0-ether-switch.yaml
> @@ -126,6 +126,9 @@ properties:
>            - phys
>            - mdio
>  
> +	optional:
> +	  - link-pin

Missing a definition for the property. "optional:" isn't a thing,
anything not required is optional. Clearly you didn't test this. Please
look at what every other binding does for (what I assume is) a "boolean"
or "flag" property.
pw-bot: changes-requested

> +
>  required:
>    - compatible
>    - reg
> 
> -- 
> 2.43.0
>

Attachment: signature.asc
Description: PGP signature