Re: [PATCH v2 10/16] tracing: Guard __DECLARE_TRACE() use of __DO_TRACE_CALL() with SRCU-fast

From: Steven Rostedt

Date: Thu Nov 06 2025 - 12:10:15 EST


On Thu, 6 Nov 2025 09:01:30 -0800
"Paul E. McKenney" <paulmck@xxxxxxxxxx> wrote:

> On Thu, Nov 06, 2025 at 11:02:30AM -0500, Steven Rostedt wrote:
> > On Wed, 5 Nov 2025 12:32:10 -0800
> > "Paul E. McKenney" <paulmck@xxxxxxxxxx> wrote:
> > >
> > > The current commit can be thought of as an approximate revert of that
> > > commit, with some compensating additions of preemption disabling pointed
> > > out by Steven Rostedt (thank you, Steven!). This preemption disabling
> >
> > > uses guard(preempt_notrace)(), and while in the area a couple of other
> > > use cases were also converted to guards.
> >
> > Actually, please don't do any conversions. That code is unrelated to
> > this work and I may be touching it. I don't need unneeded conflicts.
>
> OK, thank you for letting me know. Should I set up for the merge window
> after this coming one (of course applying your feedback below), or will
> you be making this safe for PREEMPT_RT as part of your work?

Just don't convert the open coded preempt_disable() to a guard(). That's
the code I plan on touching. The rest is fine (with my suggestions ;-)

-- Steve