Re: [PATCH 4/4] power: sequencing: Add the Power Sequencing driver for the PCIe M.2 connectors

From: Bartosz Golaszewski

Date: Thu Nov 06 2025 - 10:48:33 EST


On Thu, Nov 6, 2025 at 3:32 PM Manivannan Sadhasivam <mani@xxxxxxxxxx> wrote:
>
> >
> > To answer your question: sure, there is nothing wrong with having a
> > default match callback but first: I'd like to see more than one user
> > before we generalize it, and second: it still needs some logic. What
> > is the relationship between the firmware nodes of dev and pwrseq here
> > exactly?
> >
>
> The 'dev' belongs to the PCIe Root Port node where the graph port is defined:
>
> &pcie6_port0 {
> ...
> port {
> pcie6a_port0_ep: endpoint {
> remote-endpoint = <&m2_pcie_ep>;
> };
> };
> };
>
> So I have to do remote-endpoint lookup from the pwrseq and compare the of_node
> of the parent with 'dev->of_node', I believe. If so, this looks like a common
> pattern.
>

Sounds right. I would still keep it in this driver until we have at
least a second user that wants to do the same thing.

Bartosz