Re: [PATCH net-next 06/14] ipvlan: Support GSO for port -> ipvlan
From: Dmitry Skorodumov
Date: Thu Nov 06 2025 - 10:41:51 EST
On 05.11.2025 19:58, Dmitry Skorodumov wrote:
> On 05.11.2025 19:29, Eric Dumazet wrote:
>> On Wed, Nov 5, 2025 at 8:15 AM Dmitry Skorodumov
>> <skorodumov.dmitry@xxxxxxxxxx> wrote:
>>> If main port interface supports GSO, we need manually segment
>>> the skb before forwarding it to ipvlan interface.
>> Why ?
Hm, really, this patch is not needed at all. tap_handle_frame() already does everything needed. Looks like I had another trouble and this patch was an attempt to fix it.
>> Also I do not see any tests, for the whole series ?
> Ok, If modules like this have some kind of unit-tests, I should study it and provide it. I haven't seen this as a common practice for most of the modules here. So far all testing is made manually (likely this should be described anyway)
I see that currently there is no any tests for this ipvlan module (may be I missed something).. Do you have any ideas about tests? I'm a bit confused at the moment: designing tests from scratch - this might be a bit tricky.
Or it is enough just describe test-cases I checked manually (in some of the patches of the series)?
Dmitry