Re: [PATCH net-next v7 12/12] net: dsa: add driver for MaxLinear GSW1xx switch family
From: Vladimir Oltean
Date: Thu Nov 06 2025 - 10:30:46 EST
On Thu, Nov 06, 2025 at 03:38:04PM +0100, Paolo Abeni wrote:
> On 11/4/25 9:03 AM, Sverdlin, Alexander wrote:
> > The problems I had in the past were neither related to the GSW145 code,
> > nor to am65-cpsw-nuss, but to the test itself:
> > https://lore.kernel.org/all/20251104061723.483301-1-alexander.sverdlin@xxxxxxxxxxx/
> >
> > The remaining failing test cases are:
> > TEST: VLAN over vlan_filtering=1 bridged port: Unicast IPv4 to unknown MAC address [FAIL]
> > reception succeeded, but should have failed
> > TEST: VLAN over vlan_filtering=1 bridged port: Unicast IPv4 to unknown MAC address, allmulti [FAIL]
> > reception succeeded, but should have failed
> >
> > So far I didn't notice any problems with untagged read-word IP traffic over
> > GSW145 ports.
> >
> > Do you have a suggestion what could I check further regarding the failing
> > test cases? As I understood, all of them pass on your side?
>
> Could be that due to different revisions of the relevant H/W?
>
> I tend to think we are better off merging the series as-is, and handle
> the above with follow-up, as needed. Any different opinions?
Yeah, it's a problem with the test.
I too agree with merging as-is. I do have some nitpicks but they don't
require resending the 12-patch series.