Re: [PATCH] selftests: net: local_termination: Wait for interfaces to come up
From: Paolo Abeni
Date: Thu Nov 06 2025 - 09:53:15 EST
On 11/5/25 10:31 PM, Vladimir Oltean wrote:
> Functionally I have nothing against this change.
>
> Reviewed-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>
>
> Two ideas to minimize the delta in a more obviously correct way.
> They can perhaps be implemented together, independently of one another,
> or not at all:
>
> - setup_wait() could be used directly, as it waits for $NUM_NETIFS, aka
> $h1 and $h2.
> - There is no case where run_test() does not need a prior setup_wait()
> call, so it can just as well be placed as the first thing of that
> function.
I think both suggestions make a lot of sense, @Alexander: please send
and updated version including them. You can retain Vladimir's RB tag.
Thanks,
Paolo