Re: [PATCH 1/4] usb: host: Do not check priv->clks[clk]

From: Geert Uytterhoeven

Date: Thu Nov 06 2025 - 09:45:59 EST


Hi Claudiu,

Thanks for your patch!

On Thu, 6 Nov 2025 at 15:36, Claudiu <claudiu.beznea@xxxxxxxxx> wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
>
> There is no need to check the entries in priv->clks[] array before passing
> it to clk_disable_unprepare() as the clk_disable_unprepare() already

them ... as clk_disable_unprepare

> check if it receives a NULL or error pointer as argument. Remove this

checks

> check. This makes the code simpler.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds