Re: [PATCH v2 08/13] memory: tegra186-emc: Simplify and handle deferred probe with dev_err_probe()

[Jon Hunter]

On 06/11/2025 12:13, Krzysztof Kozlowski wrote:
> On 06/11/2025 13:04, Jon Hunter wrote:
> > > @@ -319,14 +318,13 @@ static int tegra186_emc_probe(struct platform_device *pdev)
> > >    
> > >    	emc->bpmp = tegra_bpmp_get(&pdev->dev);
> > >    	if (IS_ERR(emc->bpmp))
> > > -		return dev_err_probe(&pdev->dev, PTR_ERR(emc->bpmp), "failed to get BPMP\n");
> > > +		return dev_err_probe(&pdev->dev, PTR_ERR(emc->bpmp),
> > > +				     "failed to get BPMP\n");
> > >    
> > >    	emc->clk = devm_clk_get(&pdev->dev, "emc");
> > > -	if (IS_ERR(emc->clk)) {
> > > -		err = PTR_ERR(emc->clk);
> > > -		dev_err(&pdev->dev, "failed to get EMC clock: %d\n", err);
> > > -		goto put_bpmp;
> > > -	}
> > > +	if (IS_ERR(emc->clk))
> > > +		return dev_err_probe(&pdev->dev, PTR_ERR(emc->clk),
> > > +				     "failed to get EMC clock\n");
> >
> > I see now that we dropped a 'put_bpmp' here and we should not have. I
> > see this is in -next, do you want fix up or I can send a patch?
>
>
> Indeed, thanks for noticing this. Please send a patch with Fixes tag.
> Will you also take a look at other patches from this patchset, if I did
> not make same mistake?

Yes I will send a patch. All the others look good.

Thanks
Jon

--
nvpublic