Re: [PATCH v2 5/7] reset: eyeq: drop device_set_of_node_from_dev() done by parent
From: Philipp Zabel
Date: Thu Nov 06 2025 - 05:51:50 EST
On Sa, 2025-11-01 at 09:53 +0100, Théo Lebrun wrote:
> Our parent driver (clk-eyeq) now does the
> device_set_of_node_from_dev(dev, dev->parent)
> call through the newly introduced devm_auxiliary_device_create() helper.
>
> Doing it again in the reset-eyeq probe would be redundant.
> Drop both the WARN_ON() and the device_set_of_node_from_dev() call.
> Also fix the following comment that talks about "our newfound OF node".
>
> Signed-off-by: Théo Lebrun <theo.lebrun@xxxxxxxxxxx>
> Signed-off-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx>
Reviewed-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
and
Acked-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
to be merged via the clk tree together with patch 3.
regards
Philipp