Re: [PATCH] ASoC: codecs: va-macro: fix resource leak in probe error path

[Konrad Dybcio]

On 11/6/25 8:50 AM, Haotian Zhang wrote:
> In the commit referenced by the Fixes tag, clk_hw_get_clk()
> was added in va_macro_probe() to get the fsgen clock,
> but forgot to add the corresponding clk_put() in va_macro_remove().
> This leads to a clock reference leak when the driver is unloaded.
> 
> Add clk_put() call in va_macro_remove() to properly release the clock
> reference obtained in probe.
> 
> Fixes: 30097967e056 ("ASoC: codecs: va-macro: use fsgen as clock")
> Signed-off-by: Haotian Zhang <vulab@xxxxxxxxxxx>
> ---

You can switch the clk_hw_get_clk to devm_clk_hw_get_clk() instead

Konrad