Re: [PATCH v2 2/2] arm: dts: ti: Adds support for AM335x and AM437x

[Parvathi Pudi]

Hi,

> On 11/3/25 6:47 AM, Parvathi Pudi wrote:
>> From: Roger Quadros <rogerq@xxxxxx>
>> 
>> PRU-ICSS instance consists of two PRU cores along with various
>> peripherals such as the Interrupt Controller (PRU_INTC), the Industrial
>> Ethernet Peripheral(IEP), the Real Time Media Independent Interface
>> controller (MII_RT), and the Enhanced Capture (eCAP) event module.
>> 
>> The TI Sitara AM335x ICE-V2 consists of single PRU-ICSS instance,
>> This patch adds the new device tree source file in-order to use
>> PRU-ICSS instance, along with makefile changes to add the new DTS
>> file for PRUSS.
>> 
>> The TI Sitara AM437x series of devices consists of 2 PRU-ICSS instances
>> (PRU-ICSS0 and PRU-ICSS1). This patch adds the device tree nodes for the
>> PRU-ICSS1 instance to support DUAL-MAC mode of operation. Support for
>> Ethernet over PRU is available only for ICSS1 instance.
>> 
>> am33xx-l4.dtsi, am4372.dtsi - Adds IEP and eCAP peripheral as child nodes
>> of the PRUSS subsystem node.
>> 
>> am335x-icev2-prueth.dts, am437x-idk-evm.dts - Adds PRU-ICSS
>> instance node along with PRU eth port information and corresponding
>> port configuration. It includes interrupt mapping for packet reception,
>> HW timestamp collection, and PRU Ethernet ports in MII mode,
>> 
>> GPIO configuration, boot strapping along with delay configuration for
>> individual PRU Ethernet port and other required nodes.
>> 
>> Signed-off-by: Roger Quadros <rogerq@xxxxxx>
>> Signed-off-by: Andrew F. Davis <afd@xxxxxx>
>> Signed-off-by: Murali Karicheri <m-karicheri2@xxxxxx>
>> Signed-off-by: Basharath Hussain Khaja <basharath@xxxxxxxxxxx>
>> Signed-off-by: Parvathi Pudi <parvathi@xxxxxxxxxxx>
>> ---
>>   arch/arm/boot/dts/ti/omap/Makefile            |   1 +
>>   .../boot/dts/ti/omap/am335x-icev2-prueth.dts  | 533 ++++++++++++++++++
>>   arch/arm/boot/dts/ti/omap/am33xx-l4.dtsi      |  11 +
>>   arch/arm/boot/dts/ti/omap/am4372.dtsi         |  11 +
>>   arch/arm/boot/dts/ti/omap/am437x-idk-evm.dts  | 137 ++++-
>>   5 files changed, 692 insertions(+), 1 deletion(-)
>>   create mode 100644 arch/arm/boot/dts/ti/omap/am335x-icev2-prueth.dts
>> 
>> diff --git a/arch/arm/boot/dts/ti/omap/Makefile
>> b/arch/arm/boot/dts/ti/omap/Makefile
>> index 1aef60eef671..d06dd31d0bb6 100644
>> --- a/arch/arm/boot/dts/ti/omap/Makefile
>> +++ b/arch/arm/boot/dts/ti/omap/Makefile
>> @@ -100,6 +100,7 @@ dtb-$(CONFIG_SOC_AM33XX) += \
>>   	am335x-evmsk.dtb \
>>   	am335x-guardian.dtb \
>>   	am335x-icev2.dtb \
>> +	am335x-icev2-prueth.dtb \
> 
> This new DTB looks to be almost identical to the regular am335x-icev2.dtb, to
> add an optional node to an existing board use DT overlay, do not clone the
> whole board DT just to add a node. Maybe that is how we hacked around this
> in our evil vendor tree back in 2018 but do not take our old hacks and push
> them upstream as-is.
> 
> Andrew
> 

Understood. We will review this redundancy and revert back with an update.


Thanks and Regards,
Parvathi.