Re: [PATCH] rust: io: cleanup imports and use "kernel vertical" style

[Zhi Wang]

On Tue, 4 Nov 2025 17:25:11 +0100
Danilo Krummrich <dakr@xxxxxxxxxx> wrote:

> On 11/4/25 2:32 PM, Danilo Krummrich wrote:
> > diff --git a/rust/kernel/io/poll.rs b/rust/kernel/io/poll.rs
> > index ebc29023d59d..e21ccf98b81a 100644
> > --- a/rust/kernel/io/poll.rs
> > +++ b/rust/kernel/io/poll.rs
> > @@ -5,7 +5,10 @@
> >  //! C header:
> > [`include/linux/iopoll.h`](srctree/include/linux/iopoll.h). 
> >  use crate::{
> > -    error::{code::*, Result},
> > +    error::{
> > +        code::*,
> > +        Result, //
> > +    },
> >      processor::cpu_relax,
> >      task::might_sleep,
> >      time::{
> 
> Should instead be:
> 

LGTM. Tested on the driver-core-testing branch with this extra change.

Reviewed-by: Zhi Wang <zhiw@xxxxxxxxxx>

> diff --git a/rust/kernel/io/poll.rs b/rust/kernel/io/poll.rs
> index ebc29023d59d..b1a2570364f4 100644
> --- a/rust/kernel/io/poll.rs
> +++ b/rust/kernel/io/poll.rs
> @@ -5,7 +5,7 @@
>  //! C header:
> [`include/linux/iopoll.h`](srctree/include/linux/iopoll.h).
> 
>  use crate::{
> -    error::{code::*, Result},
> +    prelude::*,
>      processor::cpu_relax,
>      task::might_sleep,
>      time::{
>