Re: [PATCH] RAS/CEC: replace use of system_wq with system_percpu_wq
From: Marco Crivellari
Date: Thu Nov 06 2025 - 04:17:31 EST
On Wed, Nov 5, 2025 at 10:08 PM Borislav Petkov <bp@xxxxxxxxx> wrote:
> On Wed, Nov 05, 2025 at 05:55:49PM +0100, Marco Crivellari wrote:
> > The code is using system_wq, this is the per-cpu workqueue. This change will
> > only replace system_wq with system_percpu_wq. So the behavior is the same as
> > before.
>
> What does that mean?
>
> We're going away from system_wq in favor or system_percpu_wq? Or?
>
It's just a "rename" from system_wq to system_percpu_wq.
system_percpu_wq is a per-cpu workqueue, exactly as system_wq.
But in a few release cycles system_wq will be removed from the code.
If you want to have more details, you can read this discussion:
https://lore.kernel.org/all/20250221112003.1dSuoGyc@xxxxxxxxxxxxx/
> It is not clear to me what the issue is what the new correct way should be...
There is no issue, except that system_wq will be removed. In order to
achieve the same result as system_wq, the correct workqueue to use
is system_percpu_wq.
As you can see from:
commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
system_percpu_wq is defined as a per-cpu workqueue, exactly as system_wq.
Thanks!
--
Marco Crivellari
L3 Support Engineer, Technology & Product