Re: [PATCH net] net/mlx5e: Fix return value in case of module EEPROM read error
From: patchwork-bot+netdevbpf
Date: Wed Nov 05 2025 - 20:50:41 EST
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@xxxxxxxxxx>:
On Tue, 4 Nov 2025 16:15:36 +0200 you wrote:
> From: Gal Pressman <gal@xxxxxxxxxx>
>
> mlx5e_get_module_eeprom_by_page() has weird error handling.
>
> First, it is treating -EINVAL as a special case, but it is unclear why.
>
> Second, it tries to fail "gracefully" by returning the number of bytes
> read even in case of an error. This results in wrongly returning
> success (0 return value) if the error occurs before any bytes were
> read.
>
> [...]
Here is the summary with links:
- [net] net/mlx5e: Fix return value in case of module EEPROM read error
https://git.kernel.org/netdev/net/c/d1c94bc5b90c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html