Re: [PATCH 2/2] arm64: dts: qcom: hamoa: enable ETR and CTCU devices

[Jie Gan]

On 11/5/2025 5:17 PM, Krzysztof Kozlowski wrote:
> On 05/11/2025 10:09, Konrad Dybcio wrote:
> > On 11/5/25 2:14 AM, Jie Gan wrote:
> > > On 11/4/2025 8:47 PM, Konrad Dybcio wrote:
> > > > On 11/4/25 9:10 AM, Jie Gan wrote:
> > > > > Embedded Trace Router(ETR) is working as a DDR memory sink to collect
> > > > > tracing data from source device.
> > > > >
> > > > > The CTCU serves as the control unit for the ETR device, managing its
> > > > > behavior to determine how trace data is collected.
> > > > >
> > > > > Signed-off-by: Jie Gan <jie.gan@xxxxxxxxxxxxxxxx>
> > > > > ---
> > > > >    arch/arm64/boot/dts/qcom/hamoa.dtsi | 160 +++++++++++++++++++++++++++++++++++-
> > > > >    1 file changed, 159 insertions(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/arch/arm64/boot/dts/qcom/hamoa.dtsi b/arch/arm64/boot/dts/qcom/hamoa.dtsi
> > > > > index a17900eacb20..ca4a473614ee 100644
> > > > > --- a/arch/arm64/boot/dts/qcom/hamoa.dtsi
> > > > > +++ b/arch/arm64/boot/dts/qcom/hamoa.dtsi
> > > > > @@ -6713,6 +6713,35 @@ data-pins {
> > > > >                };
> > > > >            };
> > > > >    +        ctcu@10001000 {
> > > > > +            compatible = "qcom,hamoa-ctcu","qcom,sa8775p-ctcu";
> > > >
> > > > Missing space between after the comma
> > > >
> > > > no issues otherwise
> > >
> > > sorry for the mistake. Do I need send a new version to fix it?
> >
> > I think you do since Krzysztof made some comments
>
>
> Not a technical ones, but about the process.

will send a new version to address all comments.

Thanks,
Jie

> Best regards,
> Krzysztof