Re: [PATCH v2 05/12] nova-core: gsp: Add support for checking if GSP reloaded

[Alexandre Courbot]

On Thu Nov 6, 2025 at 8:18 AM JST, Lyude Paul wrote:
> Minor comments:
>
> On Sun, 2025-11-02 at 18:59 -0500, Joel Fernandes wrote:
>> During the sequencer process, we need to check if GSP was successfully
>> reloaded. Add functionality to check for the same.
>> 
>> Signed-off-by: Joel Fernandes <joelagnelf@xxxxxxxxxx>
>> ---
>>  drivers/gpu/nova-core/falcon/gsp.rs | 18 ++++++++++++++++++
>>  drivers/gpu/nova-core/regs.rs       |  6 ++++++
>>  2 files changed, 24 insertions(+)
>> 
>> diff --git a/drivers/gpu/nova-core/falcon/gsp.rs b/drivers/gpu/nova-core/falcon/gsp.rs
>> index f17599cb49fa..e0c0b18ec5bf 100644
>> --- a/drivers/gpu/nova-core/falcon/gsp.rs
>> +++ b/drivers/gpu/nova-core/falcon/gsp.rs
>> @@ -1,5 +1,11 @@
>>  // SPDX-License-Identifier: GPL-2.0
>>  
>> +use kernel::{
>> +    io::poll::read_poll_timeout,
>> +    prelude::*,
>> +    time::Delta, //
>
> Looks like a wild // got loose!

It's a bit confusing at first but this is to conform with the new rules
for imports. :)

https://docs.kernel.org/rust/coding-guidelines.html#imports

Thanks for the reviews!