Re: [PATCH 4/6] kallsyms/ftrace: Set module buildid in ftrace_mod_address_lookup()
From: Steven Rostedt
Date: Wed Nov 05 2025 - 11:22:06 EST
On Wed, 5 Nov 2025 15:23:16 +0100
Petr Mladek <pmladek@xxxxxxxx> wrote:
> __sprint_symbol() might access an invalid pointer when
> kallsyms_lookup_buildid() returns a symbol found by
> ftrace_mod_address_lookup().
>
> The ftrace lookup function must set both @modname and @modbuildid
> the same way as module_address_lookup().
>
> Fixes: 9294523e3768 ("module: add printk formats to add module build ID to stacktraces")
> Signed-off-by: Petr Mladek <pmladek@xxxxxxxx>
> ---
> include/linux/ftrace.h | 6 ++++--
> kernel/kallsyms.c | 4 ++--
> kernel/trace/ftrace.c | 5 ++++-
> 3 files changed, 10 insertions(+), 5 deletions(-)
Acked-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>
-- Steve