Re: [PATCH v2] reset: fix BIT macro reference

[Troy Mitchell]

On Wed, Nov 05, 2025 at 11:40:12PM +0800, Encrow Thorne wrote:
> RESET_CONTROL_FLAGS_BIT_* macros use BIT(), but reset.h does not
> include bits.h or bitops.h. This causes compilation errors when
> including reset.h standalone.
> 
> Include bits.h to make reset.h self-contained.
> 
> Suggested-by: Troy Mitchell <troy.mitchell@xxxxxxxxx>
> Reviewed-by: Troy Mitchell <troy.mitchell@xxxxxxxxx>
> Signed-off-by: Encrow Thorne <jyc0019@xxxxxxxxx>
> ---
> Changes in v2:
> - EDITME: describe what is new in this series revision.
> - EDITME: use bulletpoints and terse descriptions.
> - Link to v1: https://lore.kernel.org/r/20251105-rfc-reset-include-bits-v1-1-d7e1bbc7e1ab@xxxxxxxxx
What's that?

    - Troy
> ---
>  include/linux/reset.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/reset.h b/include/linux/reset.h
> index 840d75d172f6..44f9e3415f92 100644
> --- a/include/linux/reset.h
> +++ b/include/linux/reset.h
> @@ -2,6 +2,7 @@
>  #ifndef _LINUX_RESET_H_
>  #define _LINUX_RESET_H_
>  
> +#include <linux/bits.h>
>  #include <linux/err.h>
>  #include <linux/errno.h>
>  #include <linux/types.h>
> 
> ---
> base-commit: 8fec172c82c2b5f6f8e47ab837c1dc91ee3d1b87
> change-id: 20251105-rfc-reset-include-bits-4ec72344d1a3
> 
> Best regards,
> -- 
> Encrow Thorne <jyc0019@xxxxxxxxx>
>