Re: [PATCH v2] reset: fix BIT macro reference
From: Philipp Zabel
Date: Wed Nov 05 2025 - 10:51:36 EST
On Mi, 2025-11-05 at 23:40 +0800, Encrow Thorne wrote:
> RESET_CONTROL_FLAGS_BIT_* macros use BIT(), but reset.h does not
> include bits.h or bitops.h. This causes compilation errors when
^^^^^^^^^^^
Troy suggested "or bitops.h" can be dropped.
> including reset.h standalone.
>
> Include bits.h to make reset.h self-contained.
>
> Suggested-by: Troy Mitchell <troy.mitchell@xxxxxxxxx>
> Reviewed-by: Troy Mitchell <troy.mitchell@xxxxxxxxx>
> Signed-off-by: Encrow Thorne <jyc0019@xxxxxxxxx>
> ---
> Changes in v2:
> - EDITME: describe what is new in this series revision.
> - EDITME: use bulletpoints and terse descriptions.
These should be replaced with a short description of the changes
relative to v1.
Otherwise,
Reviewed-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
regards
Philipp