Re: [PATCH 2/2] iio: accel: adxl380: add support for ADXL318 and ADXL319
From: Andy Shevchenko
Date: Wed Nov 05 2025 - 10:11:09 EST
On Wed, Nov 05, 2025 at 09:40:34AM -0300, Jonathan Santos wrote:
> The ADXL318 and ADXL319 are low noise density, low power, 3-axis
> accelerometers based on ADXL380 and ADXL382, respectively. The main
> difference between the new parts and the existing ones are the absence
> of interrupts and events like tap detection, activity/inactivity, and
> free-fall detection.
>
> Other differences in the new parts are fewer power modes, basically
> allowing only idle and measurement modes, and the removal of the 12-bit
> SAR ADC path for the 3-axis signals (known as lower signal chain),
> being excluisive for the temperature sensor in the ADXL318/319.
...
> struct adxl380_chip_info {
> const int samp_freq_tbl[3];
> const int temp_offset;
> const u16 chip_id;
> + const struct iio_info *info;
> + const bool has_low_power;
> };
You can save a few bytes here. Please, run `pahole` to see ways to improve
the layout.
Other than that, LGTM,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
--
With Best Regards,
Andy Shevchenko