Re: [PATCH] rtlwifi: rtl8188ee: remove an accidental '-' character
From: Dan Carpenter
Date: Wed Nov 05 2025 - 09:54:23 EST
On Mon, Nov 03, 2025 at 01:17:07AM +0000, Ping-Ke Shih wrote:
> Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> > Sent: Friday, October 31, 2025 9:04 PM
> > The "->allstasleep" variable is a 1 bit bitfield. It can only be
> > 0 or 1. This "= -1" assignement was supposed to be "= 1". This
> > doesn't change how the code works, it's just a cleanup.
>
> Yes, this patch doesn't change logic at all. However, it looks like existing
> code is wrong, since other places in the same pattern in this driver set to 0.
> More, I check vendor driver which also sets this value to 0.
>
Ah. Good. Thanks.
Could you send that patch and give me a Reported-by tag?
regards,
dan carpenter