Re: [PATCH RFC] reset: fix BIT macro reference

[Philipp Zabel]

Hi,

On Mi, 2025-11-05 at 21:35 +0800, Encrow Thorne wrote:
> RESET_CONTROL_FLAGS_BIT_* macros use BIT(), but reset.h does not
> include bits.h or bitops.h. This causes compilation errors when
> including reset.h standalone.
> 
> Include bits.h to make reset.h self-contained.
> 
> This patch is sent as RFC to discuss whether including bits.h in
> reset.h is appropriate.

Yes, this is appropriate, thank you.

> Signed-off-by: Encrow Thorne <jyc0019@xxxxxxxxx>
> ---
>  include/linux/reset.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/reset.h b/include/linux/reset.h
> index 840d75d172f6..d3102eef085e 100644
> --- a/include/linux/reset.h
> +++ b/include/linux/reset.h
> @@ -5,6 +5,7 @@
>  #include <linux/err.h>
>  #include <linux/errno.h>
>  #include <linux/types.h>
> +#include <linux/bits.h>

Please keep includes sorted alphabetically.

regards
Philipp