Re: [PATCH v1 02/10] pinctrl: alderlake: Switch to INTEL_GPP() macro

[Andy Shevchenko]

On Wed, Nov 05, 2025 at 11:31:22AM +0100, Mika Westerberg wrote:
> On Tue, Nov 04, 2025 at 03:56:36PM +0100, Andy Shevchenko wrote:
> > Replace custom macro with the recently defined INTEL_GPP().

...

> > -#define ADL_GPP(r, s, e, g)				\
> > -	{						\
> > -		.reg_num = (r),				\
> > -		.base = (s),				\
> > -		.size = ((e) - (s) + 1),		\
> > -		.gpio_base = (g),			\
> > -	}
> 
> I wonder if simply doing this:
> 
> #define ADL_GPP(r, s, e, g)	INTEL_GPP(r, s, e, g)

We can, but it will give a couple of lines in each driver still be left.
Do you think it's better?

> is better? Then the amount of changes are smaller.

-- 
With Best Regards,
Andy Shevchenko