Re: [PATCH] gpio: aggregator: restore the set_config operation

[Bartosz Golaszewski]

On Wed, Nov 5, 2025 at 10:59 AM Thomas Richard
<thomas.richard@xxxxxxxxxxx> wrote:
>
> Hi Bartosz,
>
> On 9/29/25 2:45 PM, Bartosz Golaszewski wrote:
> > On Mon, Sep 29, 2025 at 12:03 PM Thomas Richard
> > <thomas.richard@xxxxxxxxxxx> wrote:
> >>
> >> Restore the set_config operation, as it was lost during the refactoring of
> >> the gpio-aggregator driver while creating the gpio forwarder library.
> >>
> >> Fixes: b31c68fd851e7 ("gpio: aggregator: handle runtime registration of gpio_desc in gpiochip_fwd")
> >> Reported-by: kernel test robot <oliver.sang@xxxxxxxxx>
> >> Closes: https://lore.kernel.org/oe-lkp/202509281206.a7334ae8-lkp@xxxxxxxxx
> >> Signed-off-by: Thomas Richard <thomas.richard@xxxxxxxxxxx>
> >> ---
> >>  drivers/gpio/gpio-aggregator.c | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/gpio/gpio-aggregator.c b/drivers/gpio/gpio-aggregator.c
> >> index 37600faf4a4b728ceb1937538b3f6b78ab3e90fa..416f265d09d070ee33e30bf6773e9d8fffc242bd 100644
> >> --- a/drivers/gpio/gpio-aggregator.c
> >> +++ b/drivers/gpio/gpio-aggregator.c
> >> @@ -723,6 +723,7 @@ struct gpiochip_fwd *devm_gpiochip_fwd_alloc(struct device *dev,
> >>         chip->get_multiple = gpio_fwd_get_multiple_locked;
> >>         chip->set = gpio_fwd_set;
> >>         chip->set_multiple = gpio_fwd_set_multiple_locked;
> >> +       chip->set_config = gpio_fwd_set_config;
> >>         chip->to_irq = gpio_fwd_to_irq;
> >>         chip->base = -1;
> >>         chip->ngpio = ngpios;
> >>
> >> ---
> >
> > Thanks for fixing it. I saw the report but I had already prepared my
> > big PR for Linus. This will still make v6.18-rc1, I will send it later
> > into the merge window. Please address Geert's review.
>
> Gentle ping, just in case of you forgot it :)
> Geert sent his Reviewed-by tag.
>
> Best Regards,
> Thomas
>

It did indeed escape my attention, thanks for the heads-up. Now queued.

Bartosz