Re: [PATCH v5 1/2] dt-bindings: firmware: svc: Add IOMMU support for Agilex5

[Romli, Khairul Anuar]

On 5/11/2025 4:23 pm, Krzysztof Kozlowski wrote:
> On Wed, Nov 05, 2025 at 10:28:01AM +0800, Khairul Anuar Romli wrote:
>> In Agilex5, the TBU (Translation Buffer Unit) can now operate in non-secure
>> mode, enabling Linux to utilize it through the IOMMU framework. This allows
>> improved memory management capabilities in non-secure environments. With
>> Agilex5 lifting this restriction, we are now extending the device tree
>> bindings to support IOMMU for the Agilex5 SVC.
>>
>> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@xxxxxxxxxx>
>> ---
>> Changes in v5:
>> 	- Use contains enum instead of const
>> Changes in v4:
>> 	- Fix syntax / style error.
>> 	- Refactor code not to use AllOf but instead use if directly.
> 
> Why? I would expect there allOf, so you won't re-indent when next
> if:then: clause comes.
> 
Sure, I will put back the AllOf so that the future changes that require 
different property can be added within that block.

> Anyway, slow down with your patches - one posting per 24h. That's like
> three versions within that timeframe...

Sure, I will slow down to send the next version.

> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> 
Can I add this in my next version?

> Best regards,
> Krzysztof
>