Re: [PATCH net V2] virtio_net: fix alignment for virtio_net_hdr_v1_hash
From: Michael S. Tsirkin
Date: Wed Nov 05 2025 - 02:17:57 EST
On Fri, Oct 31, 2025 at 02:05:51PM +0800, Jason Wang wrote:
> diff --git a/include/linux/virtio_net.h b/include/linux/virtio_net.h
> index 4d1780848d0e..b673c31569f3 100644
> --- a/include/linux/virtio_net.h
> +++ b/include/linux/virtio_net.h
> @@ -401,7 +401,8 @@ virtio_net_hdr_tnl_from_skb(const struct sk_buff *skb,
> if (!tnl_hdr_negotiated)
> return -EINVAL;
>
> - vhdr->hash_hdr.hash_value = 0;
> + vhdr->hash_hdr.hash_value_lo = 0;
> + vhdr->hash_hdr.hash_value_hi = 0;
> vhdr->hash_hdr.hash_report = 0;
> vhdr->hash_hdr.padding = 0;
>
BTW is it just me or is old code space-indented here?
We should probably switch it to tabs.
--
MST