Re: [PATCH] input: elan_i2c: Add newline to sysfs attribute outputs

[Zhongqiu Han]

On 11/5/2025 12:55 PM, Dmitry Torokhov wrote:
> Hi Zhongqiu,
>
> On Thu, Oct 30, 2025 at 08:34:58PM +0800, Zhongqiu Han wrote:
> > Append newline characters to sysfs_emit() outputs in func min_show() and
> > max_show(). This aligns with common kernel conventions and improves
> > readability for userspace tools that expect newline-terminated values.
>
> This format for this driver was in use for 11 years, and there might be
> tools that do not expect newlines. I would rather leave it as is.
>
> Thanks.

Hi Dmitry,

Thanks for your review~

Sure, I agree that we should avoid breaking unknown userspace tools.


--
Thx and BRs,
Zhongqiu Han