Re: [PATCH v3 1/2] dt-bindings: firmware: svc: Add IOMMU support for Agilex5

[Romli, Khairul Anuar]

On 4/11/2025 7:39 am, Romli, Khairul Anuar wrote:
> In Agilex5, the TBU (Translation Buffer Unit) can now operate in non-secure
> mode, enabling Linux to utilize it through the IOMMU framework. This allows
> improved memory management capabilities in non-secure environments. With
> Agilex5 lifting this restriction, we are now extending the device tree
> bindings to support IOMMU for the Agilex5 SVC.
> 
> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@xxxxxxxxxx>
> Reviewed-by: Adrian Ng Ho Yin <adrianhoyin.ng@xxxxxxxxxx>
> Reviewed-by: Niravkumar L Rabara <niravkumarlaxmidas.rabara@xxxxxxxxxx>
> ---
> Changes in v3:
> 	- Add iommu property.
> 	- Add logical check where only Agilex5 required iommus
> 	- Rewrite the commit message to explain why this changes is
> 	  needed.
> Changes in v2:
> 	- Reprase commit message to exclude iommu
> ---
>   .../firmware/intel,stratix10-svc.yaml         | 20 +++++++++++++++----
>   1 file changed, 16 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml b/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml
> index fac1e955852e..094973494098 100644
> --- a/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml
> +++ b/Documentation/devicetree/bindings/firmware/intel,stratix10-svc.yaml
> @@ -34,6 +34,7 @@ properties:
>       enum:
>         - intel,stratix10-svc
>         - intel,agilex-svc
> +      - intel,agilex5-svc
>   
>     method:
>       description: |
> @@ -54,14 +55,25 @@ properties:
>         reserved memory region for the service layer driver to
>         communicate with the secure device manager.
>   
> +  iommus:
> +    maxItems: 1
> +
>     fpga-mgr:
>       $ref: /schemas/fpga/intel,stratix10-soc-fpga-mgr.yaml
>       description: Optional child node for fpga manager to perform fabric configuration.
>   
> -required:
> -  - compatible
> -  - method
> -  - memory-region
> +allOf:
> +  - required:
> +      - compatible
> +      - method
> +      - memory-region
> +  - if:
> +      properties:
> +        compatible:
> +          const: intel,agilex5-svc

I am sending the next revision to use contains: enum: instead of const.
> +    then:
> +      required:
> +        - iommus
>   
>   additionalProperties: false
>