Re: [PATCH v2] media: iris: Refine internal buffer reconfiguration logic for resolution change

From: Val Packett

Date: Tue Nov 04 2025 - 18:50:32 EST



On 11/4/25 2:11 AM, Dikshita Agarwal wrote:
[..]
--- a/drivers/media/platform/qcom/iris/iris_common.c
+++ b/drivers/media/platform/qcom/iris/iris_common.c
@@ -91,12 +91,13 @@ int iris_process_streamon_input(struct iris_inst *inst)
int iris_process_streamon_output(struct iris_inst *inst)
{
const struct iris_hfi_command_ops *hfi_ops = inst->core->hfi_ops;
- bool drain_active = false, drc_active = false;
enum iris_inst_sub_state clear_sub_state = 0;
int ret = 0;

[..]

Somehow, you have lost the + edited line that declares the bools.. Hence the CI failure reported for v1, and the kernel test robot message from just a couple minutes ago.

But with `bool first_ipsc = false, drain_active = false, drc_active = false;` filled in,

Tested-by: Val Packett <val@xxxxxxxxxxxx>

finally the decoder is actually usable \o/

~val