Re: [PATCH 2/6] smb/server: fix return value of smb2_notify()

From: ChenXiaoSong

Date: Fri Oct 31 2025 - 20:18:24 EST


After I finish the other patchset, I'll fully focus on developing this feature.

Thanks,
ChenXiaoSong.

On 11/1/25 8:10 AM, Namjae Jeon wrote:
On Sat, Nov 1, 2025 at 9:05 AM ChenXiaoSong
<chenxiaosong.chenxiaosong@xxxxxxxxx> wrote:

Hi Namjae,
Hi ChenXiaoSong,

I’m referring to the userspace samba code and trying to implement this
feature.
Sounds great!
There are requests from users to implement it :
https://github.com/namjaejeon/ksmbd/issues/495#issuecomment-3473472265
Thanks!

Thanks,
ChenXiaoSong.

On 11/1/25 7:56 AM, Namjae Jeon wrote:
On Fri, Oct 17, 2025 at 5:47 PM <chenxiaosong.chenxiaosong@xxxxxxxxx> wrote:

From: ChenXiaoSong <chenxiaosong@xxxxxxxxxx>

smb2_notify() should return error code when an error occurs,
__process_request() will print the error messages.

I may implement the SMB2 CHANGE_NOTIFY response (see MS-SMB2 2.2.36)
in the future.
Do you have any plans to implement SMB2 CHANGE_NOTIFY?
Thanks.