Re: [PATCH v2 1/5] dt-bindings: i2c: dw: Add Mobileye I2C controllers

From: Benoît Monin

Date: Thu Nov 06 2025 - 04:42:48 EST


Hi Conor,

On Friday, 31 October 2025 at 15:58:49 CET, Conor Dooley wrote:
> On Fri, Oct 31, 2025 at 03:35:39PM +0100, Benoît Monin wrote:
> > Add compatible string for the I2C controllers present in Mobileye
> > Eyeq6Lplus SoC. The same controllers are also present in the EyeQ7H.
>
> Then where is the compatible for the q7h?
>
I had both entries in version 1 of the patch but Krzysztof told me to
avoid creating duplicated entries. Should I just drop the EyeQ7H
mention in the commit message?

> pw-bot: changes-requested
>
> >
> > Signed-off-by: Benoît Monin <benoit.monin@xxxxxxxxxxx>
> > ---
> > Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml b/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml
> > index d904191bb0c6..bc84631f28d1 100644
> > --- a/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml
> > +++ b/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml
> > @@ -36,6 +36,7 @@ properties:
> > const: baikal,bt1-sys-i2c
> > - items:
> > - enum:
> > + - mobileye,eyeq6lplus-i2c
> > - mscc,ocelot-i2c
> > - sophgo,sg2044-i2c
> > - thead,th1520-i2c
> >
>

Best regards,
--
Benoît Monin, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com