Re: [PATCH net] net: fec: correct rx_bytes statistic for the case SHIFT16 is set

From: Jakub Kicinski

Date: Fri Nov 07 2025 - 21:59:39 EST


On Thu, 6 Nov 2025 10:14:21 +0800 Wei Fang wrote:
> ndev->stats.rx_bytes += pkt_len;
> + if (fep->quirks & FEC_QUIRK_HAS_RACC)
> + ndev->stats.rx_bytes -= 2;

Orthogonal to this patch, but why not:

ndev->stats.rx_bytes += pkt_len - sub_len;

? Is this driver intentionally counting FCS as bytes?