Re: [PATCH v2 5/5] remoteproc: imx_rproc: Add support for i.MX95

[Daniel Baluta]

On Fri, Oct 31, 2025 at 4:27 AM Peng Fan <peng.fan@xxxxxxx> wrote:
>
> Add imx_rproc_cfg_imx95_m7 and address(TCM and DDR) mapping.
> Add i.MX95 of_device_id entry.
>
> Signed-off-by: Peng Fan <peng.fan@xxxxxxx>

With the minor comment below, you can add my:

Reviewed-by: Daniel Baluta <daniel.baluta@xxxxxxx>

<snip>

> +static const struct imx_rproc_dcfg imx_rproc_cfg_imx95_m7 = {
> +       .att            = imx_rproc_att_imx95_m7,
> +       .att_size       = ARRAY_SIZE(imx_rproc_att_imx95_m7),
> +       .ops            = &imx_rproc_ops_sm,
> +       /* Must align with System Manager Firmware */

I would add a comment here like this:

> +       .cpuid          = 1, /* Use 1 as default cpu id for M7 core */
> +       .lmid           = 1, /* Use 1 as default Logical Machine where M7 resides */
> +};
> +